If the file is written without binmode, it will have been corrupted and will likely be irrecoverable. Simply re-opening the file and stripping newlines is unlikely to work as the binary file may have containd some binary data which looks like newlines, and you would be stripping these too.

getstore doesn't allow you to pass in an open filehandle, but internally, getstore is implemented using LWP::UserAgent::request( url, $file ); and one of it's options is to allow the second parameter to be a callback address (See: LWP::USerAgent::Get() POD; ':content_cb' parameter.).

This allows a simple work around of passing in an anonymous sub that prints the content to a pre-opened, binmode'd output file:

#! perl -slw use strict; use LWP::Simple; open my $fh, '> :raw', $ARGV[ 1 ] or die $!; my $code = getstore( $ARGV[ 0 ], sub { print $fh $_[ 0 ]; } ); close $fh; print "rc=$code";

Note: I've used :raw', rather than binmode, but the effect is the same.


Examine what is said, not who speaks.
"Efficiency is intelligent laziness." -David Dunham
"Think for yourself!" - Abigail
"Memory, processor, disk in that order on the hardware side. Algorithm, algorithm, algorithm on the code side." - tachyon

In reply to Re: LWP Simple - getstore function by BrowserUk
in thread LWP Simple - getstore function by tanger

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.