If the grid method is under your control, then you can alleviate the need for the temporary var $item, and the conditional by arranging for it to return the empty list rather than undef when it has nothing to return.

#! perl -slw use strict; sub grid{ return $_[0] ? 12345 : (); } my @array = 1 .. 4; print "@array"; push @array, grid( 1 ); print "@array"; push @array, grid( 0 ); print "@array"; __END__ [20:55:29.43] P:\test>junk 1 2 3 4 1 2 3 4 12345 1 2 3 4 12345

As you can see, pushing the empty list onto the array has no effect upon it, so you save the need to test the return and a temporary variable.

If it isn't under your control and you need to use the temp var and a test, your second working form is probably slightly preferable to the first as at least the temp var goes away, and should you need to do the same thing further down you can use the same temp var name and code form without conflict.

#! perl -slw use strict; sub grid{ return $_[0] ? 12345 : (); } my @array = 1 .. 4; print "@array"; if( my $item = grid( 1 ) ) { push @array, $item; } if( my $item = grid( 1 ) ) { push @array, $item; } print "@array"; __END__ [21:01:53.53] P:\test>junk 1 2 3 4 1 2 3 4 12345 12345

Examine what is said, not who speaks.
"Efficiency is intelligent laziness." -David Dunham
"Think for yourself!" - Abigail
"Memory, processor, disk in that order on the hardware side. Algorithm, algorithm, algorithm on the code side." - tachyon

In reply to Re: Scoping question by BrowserUk
in thread Scoping question by Dr. Mu

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.