Thanks ysth, much obliged.
Just to clarify here, what were fixes and what were style issues? For instance these changes to me seem to be putely stylistic.
--- justcode.orig 2004-11-04 03:26:21.186067200 -0800 +++ justcode 2004-11-04 03:26:55.825876800 -0800 @@ -71,8 +71,7 @@ unless ($depth) { # version 00: original format # version 01: keys are escaped, not just values, handles nest +ed refs. - $vars_str =~ s/^(==\d\d)://; - unless (defined $1) { + unless ($vars_str =~ s/^(==\d\d)://) { # No format/format version "00" my %vars = map split(/=/, $_, 2), split /&/, $vars_str; unescape( values %vars ); @@ -84,9 +83,9 @@ } } - my $vars; - $vars_str =~ s/^([AHUV])(.)?//; - my ($type,$split)=($1,$2); + my $vars; + my ($type,$split); + ($type,$split) = ($1,$2) if $vars_str =~ s/^([AHUV])(.)?//; unless (defined $type) { printLog("Undefined type in unpackVars()");
The before and after there seem to me to be functionally identical. Am I right?
update:Nope, failed matches dont reset the regex vars.
In reply to Re^8: patchable settings (minor fixes, applied to test server)
by demerphq
in thread patchable settings
by ysth
| For: | Use: | ||
| & | & | ||
| < | < | ||
| > | > | ||
| [ | [ | ||
| ] | ] |