For starters, don't use prototypes unless required. In other words, drop the () on the sub line.

It would probably be better to pass the file name as a parameter.

You should localize your file handle.

I see that @lines is not declared either. I don't see any reason for this to be a global. This is probably the reason you're seeing the wrong config file.

sub read_the_config {
   my ($file) = @_;
   my @lines;
   local *CFG;
   open(CFG, "<$file") || log_error("Problem reading $file - $!");
   while (<CFG>) {
   ...
   return \@lines;
}

[download]

In newer version of Perl (don't know which exactly, but <updated>at least since 5.6.1</updated>), you can get rid of the local completely:

sub read_the_config {
   my ($file) = @_;
   my @lines;
   my $cfg_fh;
   open($cfg_fh, "<$file") || log_error("Problem reading $file - $!");
   while (<$cfg_fh>) {
   ...
   return \@lines;
}

[download]

In reply to Re: mod_perl leaking variables? by ikegami
in thread mod_perl - local vs my... by smullis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.