I could almost write a book; I wouldn't say the code I maintain is downright *horrible*, because it does get the job done, and it does a remarkably complex task. Also, the code author learned Perl as she developed this working code. Quite an impressive feat, IMO.

One part of this large system (of legacy code) I maintain is replete with globals, some of which get set in various subroutines, not a package in sight, very little thought given to code re-use, and 30-line subs that do things that a routine like 

sub percent {
    my ($num, $denom) = @_;
    $denom > 0 ? sprintf("%2.1f%%", ($num/$denom) *100) : "00.0%";
}

[download]
does.

Philosophy can be made out of anything. Or less -- Jerry A. Fodor

In reply to RE: (kudra: clarification) RE: Code Clinic by arturo
in thread Code Clinic by arturo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.