Note that an empty string is equivalent to a 'false' value, while a populated one is 'true' (unless it evaluates to a numeric zero). You can also get rid of your
!'s by reversing your AND/OR tests and negating the original terms:
sub chkfmt {
if ((!$DISCPCNT || !$DISCDAYSDUE || !$NETDAYSDUE || $NETDUEDATE ||
+$TERMSDISCAMT) ||
(!$DISCDUEDATE || !$TERMSDISCAMT || $DISCPCNT || $DISCDAYSDUE |
+| $NETDUEDATE || $NETDAYSDUE) ||
(!$DISCPCNT || !$DISCDUEDATE || $DISCDAYSDUE || $NETDUEDATE ||
+$NETDAYSDUE || $TERMSDISCAMT))
{
print TSERROUT "...";
}
}
Note that with all of these negation reversals in my head, I might have messed up your original logic. Take a look at that and see if you can follow it, making corrections as appropriate. Even if I got everything right in the translation, the code above still may not match what you're wanting if your original code was broken to begin with. Hope this helps.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.