Came across some code I just had to share. How many steps is this programmer from good, idiomatic perl?

sub padfield {
   my ( $value, $fieldlength ) = @_;
   
   while ( length $value < $fieldlength ) {
      my $pad = '0';
      $value = join( '', $pad, $value );

   }
   return $value;
}

[download]
  1. A creative use of join(). But why not just use simple string contcatenation: $value = $pad . $value ?
  2. You could use the string repetition operator $value = ("0" x ($fieldlength - length $value )) . $value.
  3. Or you could use take the right substring of an over-padded string.
  4. But even a C or Java programmer should know printf padded formats: return sprintf "%0$fieldlengthd", $value.

--
TTTATCGGTCGTTATATAGATGTTTGCA

In reply to Re: The joys of bad code by TomDLux
in thread The joys of bad code by BUU

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.