Sure.
sub Got_Command ($$) { # bad routine name. Sounds like it should return a boolean. # icky prototypes! Should be: # sub Got_Command { my $Command = $1; # EXEC Command - defined earlier my $Request_id = $2; # bad variable names--should be lowercase # bad parameter passing--do you mean # my ($command, $request_id) = @_[0,1]; ? # Pass parameters to a stored procedure print "$Command\n"; my $sthB_A = $dbh->prepare("$Command") or die "Couldn't prepare query: ".$dbh->errstr; # useless use of quotes--prepare($command) $sthB_A->execute() or die "Couldn't execute query: ".$sthB_A->errstr; ########################################## # Return Results here # ########################################## # lame comment style--hard on the eyes # also it appears you need to "use strict" $Return_results = "Select * from Result_storage_keep where Unique_id +entifier = '".$Request_id."'\;"; # should enumerate select columns and use # SQL statement placeholders, i.e. # my $return_results = "Select col1, col2 from # Result_storage_keep where Unique_id=?"; my $get_results_B = $dbh->prepare("$Return_results") or die "Couldn +'t prepare query: ".$dbh->errstr; # more useless use of quotes, prepare($results) $get_results_B->execute() or die "Couldn't execute query: ".$get_results_B->errstr; while (my @row = $get_results_B->fetchrow_array ) { } foreach (@row){ print OUTPUT_FILE "$item0\n"; # where does $item0 come from? } }

In reply to Re: DBI use by trammell
in thread DBI use by Win

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.