Tell the lead software engineer that Perl gurus recommend making variables available with the smallest possible declared scope. And lexical is preferred over dynamic scoping. The above code works fine in Perl from version 5.004 onwards and gives you maximal protection against accidentally using the same variable twice for two different things.

If you need to work with 5.003, then avoid. Otherwise I would recommend this style in general.

Although doing it in a while loop is not normal for me. Usually I do things like: 

foreach my $thing (@list) {
    #Something interesting
}

[download]

In reply to RE (tilly) 1: redeclaring variables with 'my' by tilly
in thread redeclaring variables with 'my' by tune

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.