You've gotten good advice on the uninitialized value warnings.

I'd just like to note an alternative way to write this. Your max function can be written in terms of the trinary operator, 

sub meth3 {
    my ($first, $second) = map {$_ || 0} @_;
    $first > $second ? $first : $second;
}

[download]
I've used map as an alternative to the separate ||= statements. This function is neither worse nor better than yours, other than being smaller and maybe faster. Trinary has advantages when writing lvalue subs, since trinary op produces an lvalue.

After Compline,
Zaxo

In reply to Re: Dealing with Use of uninitialised Values warning by Zaxo
in thread Dealing with Use of uninitialised Values warning by kiat

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.