After getting the dreaded "Free to wrong pool" crash in a multi-threaded Perl program (in Telnet.pm), I wrote this little program to demonstrate it:

#!/usr/bin/perl -w
# Simulate "Free to wrong pool" crash from Telnet.pm, line 1987
# This program crashes with Perl 5.8.4/5.8.5 (on multi-cpu boxes only)
+.

use strict;
use threads;

sub do_one_thread {
   my $kid  = shift;
   warn "kid $kid before local\n";
   for my $j (1..99999) {
      my @warns;
      { local $^W = 1;
        local $SIG{"__WARN__"} = sub { push @warns, @_ };
      }
   }
   warn "kid $kid after local, sleeping 1\n";
   sleep(1);
   warn "kid $kid exit\n";
}

sub do_threads {
   my $nthreads = shift;
   my @kids = ();
   for my $i (0..$nthreads-1) {
      my $t = threads->new(\&do_one_thread, $i);
      warn "parent $$: continue\n";
      push(@kids, $t);
   }
   for my $t (@kids) {
      warn "parent $$: waiting for join\n";
      $t->join();
      warn "parent $$: thread exited\n";
   }
}

do_threads(2);

[download]

This crash seems related to Perl bug #31851 ("Threading crash with closures"). It seems Perl closures are not currently thread-safe. Though all the CVs are cloned for each thread, they share the same OP tree, and the code that updates the reference count of the OP tree is not thread safe because it's missing locks (OP_REFCNT_LOCK/OP_REFCNT_UNLOCK) around some refcount decrementing (OpREFCNT_dec) and some refcount incrementing (OpREFCNT_inc).

Alas, the fix for #31851 has not yet made it back into Perl 5.8.x branch. Moreover, I'd like to have this program not crash when running on earlier Perl versions. Accordingly, I'd like to find a way to replace closures with something else that is thread-safe.

I am currently changing, for example:

local $SIG{"__WARN__"} = sub { push @warns, @_ };

[download]

to:

local $SIG{"__WARN__"} = eval <<'CLOSURE_HACK';
sub { push @warns, @_ }
CLOSURE_HACK

[download]

which seems to get rid of the crashes. Given I don't understand the code I am changing very well, can you see cases where routinely adding a leading eval like this will cause trouble? Is there an alternative way to replace closures with something else?

In reply to Replacing closures (to work around threads crash) by eyepopslikeamosquito

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.