well most of what I'm going to say is standard DBI fare. If you're going to be inserting multiple records into the same table a structure like this is preferred for speed and security.

my %items_to_insert = (item1=>1,
                       item2=>2);

$statement = "INSERT INTO myTbl (itemName,itemNumber) VALUES(?,?);
my $sth = $dbh->prepare($statement);

foreach my $key (keys(%items_to_insert))
{
   $sth->execute($key,$items_to_insert{$key});
}
[download]

That prevents the statement from being repeatedly prepare by the database handle.

I would say that one call to a fetch_all type statement in DBI rather than individual row fetching would be preferred as well. You minimize the total network traffic that way (correct me if wrong here)

So in summary, my big points of advice for DBI in this case are

• use placeholders so you only have to prepare the INSERT or DELETE statements once.
• Use fetchall methods in lieu of fetchrow

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.