Everyone loves to post bad examples from other peoples' code. But I will [once again] bravely delve into my own code archives for terrible examples!

This is at the beginning of a script that I must have written shortly after I learned about use strict. I didn't really understand lexical scope, I just wanted the errors to go away. Can we say "missing the point"?

my($all,$com,$csv,$ctr,$desc,$dir,$fname,$found,$fsize,
   $line,$longline,$null,$one);
my($parm,$parms,$pattern,$seekrc,$value);
my(@coms,@csvin,@grep,@parms,@seekrc);

[download]

Here's another fun one. I can think of one or two easier ways to do this nowadays....

    ($start,$stop,$adv,$desc) = split(/\,/,$line);
    $start =~ s/^\s+//g;
    $stop =~ s/^\s+//g;
    $adv =~ s/^\s+//g;
    $desc =~ s/^\s+//g;

[download]

Or how about something like this. I guess I didn't yet understand how to access nested hashes, because the use of %temphash is just bizarre (trimmed for pasting):

    while(defined($line = <IN>)) {
        ... 
        $temphash{'size'} = $size;
        $temphash{'crc'} = $crc;
        if($dir eq "" || $csvdirs == 1) {
            ...
            $temphash{'dir'} = $good;
        } elsif($csvdirs == 2) {
            ...
            $temphash{'dir'} = $good . "/" . $dir;
        } else {
            $temphash{'dir'} = $dir;
        }
        $bighash{$name} = { %temphash };
    }

[download]

I could go on all day, to my own humiliation. I'll leave it at that though. Perhaps others will now be tempted to post their own bad code, rather than someone else's. :-)

In reply to Re: Pearls (not really) of Perl programming by revdiablo
in thread Pearls (not really) of Perl programming by PetaMem

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.