Oh my. Where to begin? Hmm. How about here: 

while (<SHORTNAMES>) {                # loop through all lines of shor
+tnames
    my @array2 = split /:/;            # seperate by those ugly colens
+ created by OSX
    $finishedusers{$array2[7]} = $array2[0];# Setup keys:  "Long Name"
+ => "shortname"
}

[download]
What's with all of the commentary? Why not make your code self-documenting? To wit: 
open SHORTNAMES, "< $usershortfile" or die "$!";
while (<SHORTNAMES>) {
    my ($longname,$shortname) = (split /:/)[7,0];
    $finishedusers{$longname} = $shortname;
}
close SHORTNAMES;

[download]

Notice how I use descriptive variable names? Also, I closed the file when I was finished mucking with it. Good practice that. And you should also open a file quite near where you intend on using it. The USERNUMS file is open for quite a while before you ever do anything with it.

Skipping down ... surely this can't be right?

my %final;    # Hash %final
while (($fullname, $uid) = each(%final)) {    # Loop through hash

[download]

You're creating an empty hash then iterating over it. That's going to be one short loop! :-)

And even if your loop did work, it's doing too much work because you're not taking advantage of the nature of hashes but rather iterating over another hash to find the keys that match in the first one. The canonical way to do this is simply use the key from one hash as the key into the other:

while (($fullname, $uid) = each(%lookup)) {      # corrected to use %l
+ookup hash instead.
   next unless exists $finishedusers{$fullname};
   system ("cp '$oldserv/$uid/Documents/*' '$newserv/$finishedusers{$f
+ullname}/Documents/'");
   print "Copying Files for $fullname";
}

[download]

I think I'll stop there as I'm tired now.

duff

In reply to Re: I just can't see the error in this code by duff
in thread I just can't see the error in this code by gsr

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.