Nothing, but the way you state this suggests there's something wrong with map and/or grep. Why is that?

I never said that there was something wrong with grep or map, I said that the original poster's usage of grep and map combined--which didn't even work--was bad, and that in general I preferred foreach over greps and maps with multi-statement blocks.

Neither is inherently more clear than the other - people finding one construct more clear than the other usually base this preference (knowingly or not) on their experience with other languages.

I base my preference on the knowledge that variable names are perhaps the single most powerful form of documentation programmers have available to them, and one construct encourages you to give a name to list iterator while the other doesn't. Furthermore, map blocks are indeed meant to be short because each one is evaluated for its result. Thus, if you have a single statement map block like this:

my @content = map {$_->content} @responses;
[download]

It all works out nicely, but if you want to do anything more complicated, you end up combining multiple statements into one, like so:

my @content = map { escape_html(convert_newlines($_->content)) } @resp
+onses;
[download]

Or as Brian showed, separating them and then tacking on the result at the very end to make sure the block gets evaluated properly:

my @content = map {
    my $content = $_->content;

    convert_newlines($content);
    escape_html($content);

    $content;
} @responses;
[download]

And not only that, in my personal aesthetic opinion, grep/map combined with $_ are just plain uglier than foreach is, especially when you need to toss in a "+" or two to help the parser, as the OP did.

What is objectionable is to suggest that you can objectively say that foreach is clearer than map.

Did you actually bother to check the original node? Here, you compare one with the other and you decide which you think is more readable:

my $parts = [ 'Part1', 'Part2','Part3' ];
my $newLoop;

for (@$parts) {
  my $hash = { PARTNAME => $_ };

  $hash->{SELECTED}++
      if $_ eq $row->{title};

  push @$newLoop, $hash;
}

# ----

my $parts = [ 'Part1', 'Part2','Part3' ];
my $newLoop = [ map {{ PARTNAME => $_,
                        $_ eq $row->{title}
                           ? (SELECTED => 1)
                           : ()
                    }} @$parts ];
[download]

Stating that foreach is clearer than map just shows your inexperience in programming techniques.

Well, I've posted lots of code here before, so I'm more than willing to let my technique speak for itself. I'll admit that I often use grep and map freely with no inhabitions at all, but not in code that ever sees the light of day. I would be less than thrilled if I was presented with a large codebase to work on full of constructs like the OP's.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.