Ah, that explains why your alternative to map starts with:

for (@$parts)

Nice name for the list iterator!

It isn't my alternative. Neither of those implementations were mine. Why don't you actually go read the original node?

IMO, clear.

And I agree, your code is clear, but not as clear as this:

my $newLoop = [];
foreach my $part (@$parts) {
    my %hash;

    $hash{PARTNAME} = $part;
    $hash{SELECTED} = 1 if ($part eq $row->{title});

    push(@$newLoop, \%hash);
}

[download]

Longer, yes, but clearer. Code is often read many more times than it is written, and it's for this reason I usually choose the clearer alternative over the shorter one.

And before you jump on me, I wouldn't use variable names like $newLoop or $hash or $part in production code, but that's what your example and the other examples used, so I used them as well.

Does that mean that subroutines that have a return value have short blocks, and any subroutine that has a long block isn't supposed to have a return value? Or does this piece of logic only apply to map blocks?

An implicit return value? In my opinion, no matter how short a subroutine is, if it returns a meaningful value, it should have an explicit return statement indicating as much, that way you can tell just by looking at it whether its return value is to be ignored. (See above.).

In reply to Re^5: "advanced" Perl functions and maintainability by William G. Davis
in thread "advanced" Perl functions and maintainability by geektron

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.