I accept your point about only applying the test to TXT records, and have modified the proposed patch accordingly.

However, your regex doesn't work for the observed bug. Using the code from twilde's original bug report:

Your regex: 

my $rr = Net::DNS::RR->new_from_string(
'badtxt.krellis.us. 1234 TXT "something ;something else"'
);

print '"', $rr->rr_rdata, '"', "\n";

[download]

Gives: 

""

[download]

My patch gives: 

"something ;something else"

[download]

I also disagree with you assertion that the patch won't allow backslashed quotes within TXT RDATA. e.g.: 

my $rr = Net::DNS::RR->new_from_string(
'badtxt.krellis.us. 1234 TXT "something \" ; \" something else"'
);

print '"', $rr->rr_rdata, '"', "\n";

[download]

Gives: 

"something " ; " something else"

[download]

In reply to Re^2: Net::DNS::RR patch by slife
in thread Net::DNS::RR patch by slife

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.