Starting out with a value and modifying it piecemeal as you go through a list of something, which you do with $ret and the digits in both functions, is an ideal candidate for List::Util's reduce function.

use List::Util qw( reduce );

sub bin2dec {
    my ( $str ) = @_;
    reduce { mul2( $a, $b ) } "", split //, $str;
}

[download]

Here, in the first iteration, $a is the empty string from the list passed to reduce, and $b is the first digit. The return value of the block is passed back to the block as $a in the next iteration, while $b goes through the all the remaining values from the list one by one.

$add_one_f I'd rename as $have_overflow, which documents intent rather than implementation. And if you only use it as a boolean, you don't need to initialize it either.

The for(;;) loop isn't necessary, you don't use the index anywhere, you just extract each corresponding character once. So you could rewrite that much more clearly as for( reverse split //, $str ). Then it could be turned into a reduce in the same way as above, but since you're just accumulating characters onto the front of a string, you are better served with a join reverse map.

sub mul2 {
    my ( $str, $have_overflow ) = @_;

    my $ret = join '', reverse map {
        my $c = $_ * 2 + ( $have_overflow ? 1 : 0 );
        $have_overflow = ( $c >= 10 );
        ( $c % 10 );
    } reverse split //, $str;

    ( $have_overflow ? 1 : '' ) . $ret;
}

[download]

You could even get rid of the out-of-band overflow check at the bottom if you rearrange things a little:

sub mul2 {
    my ( $str, $have_overflow ) = @_;
    join '', reverse map {
        my $c = $have_overflow ? 1 : 0;
        $c += $_ * 2 if length;
        $have_overflow = ( $c >= 10 );
        # return a zero char only if not at top of string
        ( $c % 10 ) or ( length() ? 0 : '' );
    } reverse '', split //, $str;
}

[download]

But in this case I find it obfuscates more than it reduces redundancy.

Incidentally, the ( $have_overflow ? 1 : '' ) above is a no-op if $have_overflow is a boolean like in this case, since 1 and the empty string are what the boolean ops return in Perl for true and false respectively. So that could be written $have_overflow . $ret, though that lacks the the benefit of documented intent.

Makeshifts last the longest.

In reply to Re: bin2dec for big numbers by Aristotle
in thread bin2dec for big numbers by spurperl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.