Looks good to me too (but that's not saying that much!)
If a print statement is a bit unwieldy I often use join to get it to read better.
print join "\n",
'<center>',
'<h3>MSHIP - my status of host IP's</h3>',
'</center>';
I would have considered
$ping instead of
$p.
I prefer a space either side of an
= (sometimes you do too, sometimes you don't!).
I think that 2 space tabs use less real estate than 4 if there is deep nesting.
foreach $_(@TMP)
could be written as
for (@TMP)
} else {
Is that what they call cuddled?
It's controversial but I put the else on a new line.
All very minor.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.