Just a minor style comment, this style of argument handling is a little bit unusual. Generally this would look like: 

sub queryDBI {
  my ($foo,$bar,$baz,$table)=@_;
  my $query="Select $foo, $bar, $baz from $table";

[download]

Directly accessing @_ is ugly and confusing and suffers from the problem that if you change the order of arguments or perhaps add a new argument somewhere in the middle making the appropriate changes is quite error prone. People occasionally do it in "tiny subs" and gurus will occasionally resort to it for their own purposes (remember @_ is magic) but to see it in code like this is a bad sign. Use named lexical copies of the arguments instead.

---
demerphq

In reply to Re: Uninitialized value warning in subrutine by demerphq
in thread Uninitialized value warning in subrutine by Deib

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.