I've written a small script which uses a module called Config.pm to read a set of global constants as config file parameters. (Why invent a new config file syntax when you can use what PERL already provides, right?). This works fine. But I want the config file constants available to all the modules in my application. But I can't get this to work. My config module, Audit::Config.pm follows:
# full path to hosts file use constant HOSTS_FILE => '/home/csssec/audit/css_hosts.txt'; # full path to local host binary use constant HOST_BIN => '/usr/bin/host'; ... 1;
Here's the script I'm using to test:
#!/usr/bin/perl -w use strict; use Audit::Config; use Check::DNSCheck; # for every host in the hosts file open(FILE, HOSTS_FILE) || die("$!\n"); while (<FILE>) { chomp($_); my $host = $_; next if ($host =~ /^(\s*)#/); my $chk = new DNSCheck($host); $chk->run(); } close(FILE);
I want Check::DNSCheck to be able to access the constants in Audit::Config as well. I've gotten this to work in a non-OO context. But I changed Check::DNSCheck to be an OO style module (with new{} sub etc) and I could no longer access the constants in Audit::Config. Check::DNSCheck code follows:
package DNSCheck; use Audit::Config; use strict; sub new { my $class = shift; my $host = shift; my $this = { host => $host, }; bless ($this, $class); } sub run { my $this = shift; my $cmd = HOST_BIN . " $this->{'host'} 2>/dev/null"; my $r = `$cmd`; if ($r !~ /has address/) { return(0); } return(1); } 1;
Running gives the following error:
Bareword "HOST_BIN" not allowed while "strict subs" in use at Check/DN +SCheck.pm line 30. Compilation failed in require at ./audit.pl line 6. BEGIN failed--compilation aborted at ./audit.pl line 6.
So Check::DnsCheck.pm obviously insn't importing the values in Audit::Config.pm, but I'm not sure why. Some insight in this would be greatly appreciated.

Is there a better way to go about this?

Thanks


In reply to Importing constants into another module by paulski

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.