If you use it more than once, it is a good candidate to put it in a module.

Of course you can seldom "translate" a subroutine directly into a module as --almost by definition-- a module should be useful in more than one place and therefore you might have to include some extra parameters to customize the routine and make it more general.

On a totally different tack: why do you want to put a space character in the variables if there is nothing passed to the subroutine? Doesn't it make the $sth->finish() if $sth; $dbh->disconnect() if $dbh; superfluous as now you will always succeed in these tests (space is considered TRUE!)?

Another question (just being curious): why do you exit the subroutine always with a zero value (exit 0). The reason cannot be that you want to check the return value of the subroutine as it is always zero? Hence the question, why zero?

CountZero

"If you have four groups working on a compiler, you'll get a 4-pass compiler." - Conway's Law

In reply to Re: Changing a subroutine to a module by CountZero
in thread Changing a subroutine to a module by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.