First think I'd do is get rid of the for-%defaults loop: 

sub new
{
    my $class = shift;
    my $number = shift;
    my %args = (%defaults, @_);

    #...

[download]
Since anything passed in as arguments will replace anything in the defaults. On second thought... that may not work so hot for args that aren't passed in properly. Regardless, I think that you should have the transformation of keys done in a separate function, and done during import as well. Here, this should be better: 
package Foo;

use strict;
use warnings;

my %defaults =
(
    -foo => "foo",
    -bar => "bar",
);

sub import
{
    shift;
    my %def = @_;
    $defaults{_normalise_key($_)} = $def{$_} for keys %def;
}

sub _normalise_key
{
    local $_ = shift;
    s/^-?(.*)/-\L$1/;
    $_
}

sub new
{
    my $class = shift;
    my $number = shift;
    my %args = @_;

    my %realargs = %defaults;

    for ( keys %args )
    {
        my $value = $args{$_};

        $realargs{_normalise_key($_)} = $value;
    }

    my $self = bless {}, $class;

    return $self;
}

[download]
This means that normalisation of your defaults happens only once (at compile time), and not each time a Foo object is constructed.

In reply to Re: class with diversly formatted arguments by Tanktalus
in thread class with diversly formatted arguments by holli

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.