A few thoughts.
- use strict; it keeps you out of trouble
- use warnings; it helps you diagnose errors
- use POSIX; it has a nice function strftime() that is very capable of formatting dates/times
- use LWP; keep perlish. There is no need for external programs, when there is a good module (LWP) for the same task.
I rewrote your program, to give you an idea what i mean.
use strict;
use warnings;
use LWP::Simple;
use POSIX qw(strftime);
my $address = $ARGV[0] or die "No address!";
# Create Router Re-Configuration script run command
my $rtr_cfg="wscript.exe rtr-telnet.vbs";
# Create a var that holds the html and fill it
my $html = get($address) || "";
# Create a Log File
open (fail_log,">>faillog.txt");
if ( $html =~ /<\/html>/)
{
print fail_log strftime("%c - $address is up\n", localtime);
}
else
{
print fail_log strftime("%c - $address is down\n", localtime);
system ($rtr_cfg);
}
I made the address to check a parameter, so you can call that script like:
$ perl checksite.pl http://www.perlmonks.org
Update:
Added link to
strftime reference for Win32
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.