See if you can tell what the code below is going to do. Then, run it and see if it does what you think.
use strict; use warnings; # Comment out unless 5.6+ package Bar; use vars qw/ $AUTOLOAD /; sub new { bless {}, shift }; sub AUTOLOAD { print "AUTOLOAD: @_ : $AUTOLOAD\n"; my $self = shift; die "'$self' is not an object\n" unless ref($self); print "Doing some AUTOLOAD'ing magic\n"; } sub DESTROY {} sub frobnitz { my $foo = new Foo ( input => { } ); } package Foo; sub new { bless {}, shift }; package main; my $bar = Bar->new; $bar->frobnitz;

Go ahead ... I'll wait.

Now, cut'n'paste the 4 lines starting with package Foo; and paste them above package Bar; and re-run. See any differences? And, if you want, revert the code to its original, but change

my $foo = new Foo ( input => { } );
to
my $foo = Foo->new( input => { } );

That is why you shouldn't use the Indirect notation. (By the way, this was tested with 5.8.4 on Solaris.) The issue, by the way, is that the indirect notation is fixed at compile-time, not run-time. This can be seen as

my $foo = new Foo ( input => { } );
is parsed (as shown by B::Deparse) as
my $foo = new(Foo('input', {}));

Since the Foo() function (not method) doesn't exist in package Bar, AUTOLOAD is called. Since the author anticipated that AUTOLOAD would only be called as a method, the first parameter is assumed to be the object. Ooops.

Now, some anticipated responses:

Being right, does not endow the right to be rude; politeness costs nothing.
Being unknowing, is not the same as being stupid.
Expressing a contrary opinion, whether to the individual or the group, is more often a sign of deeper thought than of cantankerous belligerence.
Do not mistake your goals as the only goals; your opinion as the only opinion; your confidence as correctness. Saying you know better is not the same as explaining you know better.


In reply to Why you shouldn't use the Indirect notation with AUTOLOAD by dragonchild

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.