Very nice! This requires perl 5.8.0 and above. When I ran it with perl 5.6.1 and perl 5.005 I got the error message:

Invalid type in unpack: '(' at g.pl line 3.
Update: from perl58delta: "pack() / unpack() can now group template letters with () and then apply repetition/count modifiers on the groups". Also, I think you need to reverse the reverse and scalar. Running:
use strict; sub commify { reverse scalar join ',', unpack '(A3)*', reverse scalar shift; } sub commify2 { scalar reverse join ',', unpack '(A3)*', reverse scalar shift; } my $x = commify(1234); my $y = commify2(1234); print "x='$x' y='$y'\n"; print "comm :", commify(1234), ":\n"; print "comm2:", commify2(1234), ":\n";
produces:
x='1,234' y='1,234' comm :432,1: comm2:1,234:

In reply to Re: Commify numbers, the boring and straightforward way by eyepopslikeamosquito
in thread Commify numbers, the boring and straightforward way by Aristotle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.