Fellow monks,
In a function that reads several million rows from a database, I'm finding it is taking a very long time to complete. I recently added use warnings; to the script and am now seeing this message many times in the log:

"Use of uninitialized value in concatenation (.) or string at cf.pl line xxx"

I'm not seeing what is not initialized here. Do you?

Since this is taking a long time to complete, could you recommend any optimizations? thanks, Bryan 

use strict;
use warnings; # Added this line in last run

sub build4PartFastaFile
{
  &addDateStamp;
  my ( $fileToMake, $dbCommand ) = @_;

  open( FILE, ">$fileToMake" ) or die print "Can't open fileToMake: $!
+";

  my $sth2 = $dbh->prepare( $dbCommand ) or die print LOG "Can't prepa
+re: $! OR $DBI::errstr";
  $sth2->execute or die print LOG "Can't execute: $! OR $DBI::errstr";

  while ( ( my $giName, my $gssName, my $definition, my $sequence ) = 
+$sth2->fetchrow_array )
  {
    $sequence = uc( $sequence );
    $sequence =~ s/(\S{1,80})/$1\n/g;
    print FILE ">$giName $gssName $definition\n$sequence";
  }

  close( FILE );
}

[download]

In reply to Finding error: uninitialized value in concatenation? by bwelch

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.