An alternate design is to derive from Foo::Parse.

package Foo::Parse;

#...

sub parse {
  my $self = shift;
  if (my $func = $self->can('action'))
  {
    $self->$func(@_);
  }
}

#...

package Foo::Parse::Splitter

use base 'Foo::Parse';

sub action {
  my $self = shift;
  # ...
}

package main;

my $fp = Foo::Parse::Splitter->new('FooParser');
$fp->parse($_) while <>;
[download]

This is the way I normally do it - but I do use callbacks sometimes, and the code you have above seems fine to me, albeit quite simplified. Note that $self in the callback doesn't make much sense - it's a Foo::Parse object, and the callback is not a method of Foo::Parse. Better to name it $obj or $fp. In fact, if you split it a bit, you don't need to pass back the object at all:

my $fp;
$fp = Foo::Parse->new('FooParser',
  sub {
    local $_ = shift;
    s/^\w+:// or
      $fp->warn("something wrong!");
    split /,/;
  } );
[download]

This makes it into a closure, meaning that $fp remains visible. Even if $fp were itself no longer in scope, this closure can still see it. This is even more normal to me.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.