This code is a mess, but works. Can you refactor it?

The nastiest thing is $flag, but it's open season on the rest of it too.

It's deliberately unrunnable, as you don't have the code for f1() or f2() or any sample data. Does that make it too hard?

{ my( $indent, $depth ) = ( "\t", 0 ); sub pp { my $flag; my( $pos1, $first ) = f1( $str ); if( defined $first ) { if( $first eq CONST1 ) { $pos1++; $depth++; } else { my $pos2 = f2( $str, $first ); if( defined $pos2 ) { $pos1 = $pos2 + 2; } else { $flag = 1; } } } print $indent x $depth, substr( $str, 0, $pos1 ); $str =~ s[^.{$pos1}\s*][]; $depth++ if $flag; return; } }

Examine what is said, not who speaks.
Silence betokens consent.
Love the truth but pardon error.

In reply to Refactoring challenge. by BrowserUk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.