That is a much better way to write it, except that even using $+[0] rather than pos, the /g is still required? I do not pretend to understand that, but it is so.

Which also explains why it broke when I tried to use $-[0] originally. I would never have thought that @- and @+ where dependant upon /g? Is that a bug?

I mentioned I was embarassed by the code. My only excuse is that it evolved into the state where it worked and I've been concerned with more fundemental restructuring.

In-situ, with the /g, it makes no difference to the functioning of the code--which means your version is now in the real code.

I'm not sure what you expect $pos and $first to be when the match fails...

Nothing! If the match fails, there is nothing (or nothing further) that can be done in the call and the code just returns to the caller. If the match fails, I do not have any break point upon which to decide to output anything, so all I can do is wait until more of the string accumulates. Ie. the next call, or the one after that.


Examine what is said, not who speaks.
Silence betokens consent.
Love the truth but pardon error.

In reply to Re^3: Refactoring challenge. by BrowserUk
in thread Refactoring challenge. by BrowserUk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.