I had to take another shot at it. I noticed that comma was a sequence point, so you basically have the non-comma opening bracket match, and the comma match, which covers both closing brackets and unbracketed terms.

There may be some refactoring still left to do (update: did some more this morning), but I'm happy with it, and I need to go to bed.

sub pp_new { my( $nextBit, $width, $EOS ) = @_; $string .= $nextBit; while( length( $string ) > ($EOS ? 0 : $width) ) { for (substr($string, 0, $width)) { my $pos; my $leftmargin = $indent x $depth; if (my ($bracket) = /^[^,]*?([\Q[{\E])/) { $bracket =~ tr/[{/]}/; if (my $closepos = indexBal($_, $bracket, $width)) { $pos = $closepos + 2; } else { $pos = $+[0]; ++$depth } } else { $pos = 1 + (/,/ ? $+[0] : $width); $leftmargin = $indent x --$depth if substr($_, 0, $pos +-1) =~ /([\Q]}\E])/; } print $leftmargin, substr( $_, 0, $pos, '' ); } $string =~ s/^\s+//; } }

Caution: Contents may have been coded under pressure.

In reply to Re^2: Refactoring challenge. by Roy Johnson
in thread Refactoring challenge. by BrowserUk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.