1. There are already modules out there that do all of that sort of processing (namely CGI), so all of that code is unnecessary.

2. Even if they wanted to re-invent that parsing stuff, they could have reduced their code to, like 10% by just pumping the name=value items into a hash instead of global variables.

With any CGI script, you almost always want to be sure your script works with taint-checking enabled. This prevents people from possibly passing specially crafted, unsafe arguments to your scripts where you don't expect it, with the intent of getting those strings injected into various system commands. Taint checking does a fairly good job identifying areas where this can happen. And the use of strict/warnings means that it's infinitely easier to track down bugs or problems with the code. A large script developed without strict or warnings probably has a few undiscovered/untickled bugs that would have been identified by now.

In reply to Re: Re: Hanging my head in shame by Fastolfe
in thread Hanging my head in shame by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.