Allow me to clean it up a bit:
- use strict
- use multi-argument system calls for safety
- don't rely on $ENV{'PATH'}
- Why use Time::localtime?
#!/usr/bin/perl
use strict;
use warnings;
$ENV{'PATH'} = '';
my $zipExec = '/usr/bin/zip';
my $chownExec = '/bin/chown';
#----------------GET TIME --------------------------
sub now
{
my @time = (localtime())[3 .. 5];
return sprintf ("%02d-%02d-%04d", $time[0], $time[1] + 1, $time[2] +
+ 1900);
}
my $g = now();
print "\nThe Time NOW:\t $g\n";
print "\n-------ZIPPING DATABASE-------\n";
my $zipdbname = "dbbackup$g";
my $zipexnname = "ExnCorp$g";
system($zipExec, '-r', $zipdbname, '/var/lib/mysql/*');
print "\n-------DATABASE ZIPPED-------\n";
print "\n-------ZIPPING EXN-------\n";
system($zipExec, '-r', $zipexnname, '/var/www/html/ExnCorp/*');
print "\n-------EXN ZIPPED-------\n";
$zipdbname .= '.zip';
$zipexnname .= '.zip';
system($chownExec, 'dev:dev', $zipdbname";
system($chownExec, 'devftp:devftp', $zipexnname";
Warning: code is untested.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.