my $message_id = $1 if $message =~ m/([\w\d]+)\s+.*/;

Putting my (a compile-time directive) with an if statement modifier (which can only take place at run-time) is confusing, and therefore deprecated.

Also, there's no point at all in having .* at the end of the regexp: since one of the things it would happily match is nothing, it isn't making any restrictions at all about what can follow the \s+, so is just adding noise.

Finally, the \w class already includes digits, so writing [\w\d] doesn't add anything.

Here's how I might have written this:

$message =~ /^(\w+)/
    or die "Message '$message' doesn't start with an identifier.\n";
my $message_id = $1;

[download]

die might not be the most appropriate thing to do here; adjust as appropriate. But if you're adamant that $message could never not match the pattern, then a die test is better than nothing: if you're right, then it'll never happen, and if you're wrong then your assumption was wrong so there's a problem elsewhere and at least you found out about it.

Smylers

In reply to Re^2: Applying a regular expression to a string by Smylers
in thread Applying a regular expression to a string by mw

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.