Once you decide to use map, you probably don't need the subroutine anymore: you're not hiding that much code. Previously, you had a subroutine call like this: 

my @munged = links( $url, @links );

[download]

To replace links() with an inline map() is only a few characters longer, and it tells the programmer exactly what is happening. 

my @munged = map { "$url/$_" } @links;

[download]

However, if link() does a lot of other stuff you aren't showing us, then you may still want to use it to hide things.

As a bonus, the URI module can turn relative URLs into absolute ones for you. :)

--
brian d foy <brian@stonehenge.com>

In reply to Re: Turning foreach into map? by brian_d_foy
in thread Turning foreach into map? by ghenry

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.