Here's how I would recast your snippet:

use strict; my @values = ( 7, 38, 44, 2, 0 ); for my $number (@values) { my $product = 1; $product *= $_ for 2 .. $number; print "$number Factorial is $product\n"; }
I moved $product to inside the loop, since it's generally a good idea to limit the scope of variables as much as possible. This precaution is helpful only if running under strict, which I added. (With the exception of the fixing the foreach(;;) syntactic error that ysth already pointed out, the use strict line is probably the most important improvement in the version above.) Also note that the internal for loop does not execute if $number < 2.

Update: Fixed the missing use strict, and added explanatory remarks.

the lowliest monk


In reply to Re: back iffing with for? by tlm
in thread back iffing with for? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.