I can't immediately see the problem with your code, but what I would do is to use the tainted function from Scalar::Util to pinpoint the exactly which variable is giving you trouble.

BTW, to avoid . and .., all you need to do is 

my @files = map untaint( $_ ), grep !/^\.\.?$/, readdir DIR;

[download]
or better yet 
my @files = map untaint( $_ ), grep -f "$dir/$_", readdir DIR;

[download]
Also, the regexp in your untaint function could be written more economically as 
/([\w-]+)/

[download]
\w already implies _, and there's no need to escape - (nor _ BTW) inside the [ ] as long as it is the first or the last character in the group (e.g. [-AZ] matches -, A, and Z.).

the lowliest monk

In reply to Re: Unlink under taint mode by tlm
in thread Unlink under taint mode by Andre_br

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.