#!/usr/bin/perl
use strict;
use File::Find;

# -| Configuration |-------

my $basepath = '/sitedir/';
my @skipdirs = ( "private", "cgi-bin", "lib", "images", "files" );

# -| Main |----------------

find (\&findHandler, $basepath );


# -| Subs |----------------

sub findHandler
{ # --------------------------------------------------------
  # Evaluates and processes found files;

  # init local vars

  my $filename = $File::Find::name;
  my $dircheck = "";
  my $showfile = 1;

  # first, should we show this file?

  foreach $dircheck ( @skipdirs )
  {
    $showfile = 1;
    if ( $filename =~ /$dircheck+/i )
    {
       $showfile = 0; # skip this one;
       last;
    }
  }

  if ( $showfile )   # then do so
  {
     # first, strip leading path
     $filename =~ s/$basepath//i;

     # only after directory names.
     if ( -d ) # add dir to hash 
        {
           print "$filename\n";
        }
  }
}
[download]

When run, the above behaves as I expect, printing a list of all directories that are not being excluded by the array. (Please note that the above has been stripped down for the sake of the question.)

However, when I try to break the directory validation bit into a separate subroutine, it no longer works. Instead, it prints all of the directories, including those that were excluded in the previous version. Here's what fails to work:

#!/usr/bin/perl
use strict;
use File::Find;

# -| Configuration |-------

my $basepath = '/sitedir/';
my @skipdirs = ( "private", "cgi-bin", "lib", "images", "files" );

# -| Main |----------------

find (\&findHandler, $basepath );


# -| Subs |----------------

sub findHandler
{ # --------------------------------------------------------
  # Evaluates and processes found files;

  # init local vars

  my $filename = $File::Find::name;
  my $dircheck = "";

  if ( goodDir( $filename ) )   # then do so
  {
     # first, strip leading path
     $filename =~ s/$basepath//i;

     # only after directory names.
     if ( -d ) # add dir to hash 
        {
           print "$filename\n";
        }
  }
}  

sub goodDir    
{ # --------------------------------------------------------
  # Evaluates a file's dir to see if we want to print it.

  my $filename = $_;   # file we're testing
  my $dircheck = "";   # loop counter
  my $showfile = 1;    # assume success
  
  # first, should we show this file?

  foreach $dircheck ( @skipdirs )
  {
    $showfile = 1;
    if ( $filename =~ /$dircheck+/i )
    {
       $showfile = 0; # skip this one;
       last;          # skip rest of loop;
    }
  }
  return $showfile;

}
[download]

My question is: What am I doing wrong with my subdirectory definition? As afar as I can tell, the logic is precisely the same, though I strongly suspect I'm missing something extraordinarily simple, a Homerism.

Please note:

• The file testing looks odd because it's a fragment of the overall process.
• I realize I'm probably reinventing the wheel, but I've chosen to do so to help solidify my basic skills.
• FWIW, I'm using ActiveState v5.6.0. to develop this and will be deploying it to a BSD box.

Thanks in advance for any suggestions...