Your code looks fine to me. You might want to alert the user (or at least abort the program) if the match doesn't succeed, though.

You seem to have about the right amount of paranoia :-) Just remember that it's better to match for well-formed input instead of trying to match "bad" input. You're doing that correctly here. Also, mysql char/text/blob columns will generally handle any input that is short enough, as long as you use placeholders or $dbh->quote. You might have other reasons to restrict/quote input, though. For example, if you print user input to an HTML page, you'll probably want to use $cgi->escapeHTML(), and for a phone number, you might not want alphabetic characters...

Underscore is not part of the [A-Za-z0-9] pattern. Fortunately \w is equivalent to [A-Za-z0-9_], so you can save a few keystrokes :-)

By the way; I'd probably give users a little more characters to use in their passwords ( what about !@#$%^&*()_+{}{}:;.,<>" and ?).

"What should it profit a man, if he should win a flame war, yet lose his cool?"

In reply to Re: Regex usernames and Passwords by Joost
in thread Regex usernames and Passwords by tanger

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.