The code prints out that it has done 100% twice ;-) this is probs bad.. Hows about changing it to show the bytes read / bytes left to read. This would also allow you to change the block size for larger files. The simplest way to do this would be to incr a variable after the sysread and print that rather than the percentage. I could not see why it was printing 100% twice but I did not look hard.

On a stylistic point, why did you use a sub to print out the message, and why did you pass that sub as an arg? Just interested to hear your rational.

Nice little bit of code, ++, I have added it to my personal repository of bits of useful stuff .. nice one. --

Zigster

In reply to Re: File copy progress. by zigster
in thread File copy progress. by zzspectrez

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.