When I got here, there was no taint checking, no 'use strict', no '-w', loops which prepared the same SQL statement over and over again (no placeholders/bind_values - one of the consultants asked me what that was) and one SQL statement which forgot to strip/escape quotes from user input and pasted the input into a SQL statement. Global variables which spring into existance from who-knows-where and get used who-knows-where (on 3000 line scripts, not counting the modules, which are not real modules, just functions included from who-knows-where using a mismash of passed in and global variables!).

We are slowly getting things cleaned up, and writing new stuff alot better so it'll run under mod_perl (using Apache::Registry, we may eventually get around to writing actual mod_perl handlers), but its a nightmare working on the old code.

In reply to Re: What quality is your company's code? by runrig
in thread What quality is your company's code? by Ovid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.