Several things are wrong. /0-9/ will match '0-9' (exactly). And since it's a negated match, basically you are accepting all input unless it contains the literal text '0-9'.

You need a character class.

if( $sid =~ /^[^0-9]$/ ) {
    # exit here......
}
[download]

The above code states if there are any characters in the string that are not numbers 0 through 9, exit.

It might actually be better to do it this way though:

if( $sid !~ m/^([0-9]{1,5})$/ ) {
    # exit
} else {
    $input = $1;
}
[download]

...or better yet...

if( $sid =~ m/^([0-9]{1,5})$/ ) {
    $input = $1;
} else {
    # exit
}
[download]

I think negated matches ( the !~ operator ) are usually just a way of adding confusion, and should be avoided unless absolutely necessary.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.