Do you want to test $result_ref->{'agency_id'} is non-zero for all all the calls? That looks to me like a typo, since you first test for the "defined-ness" of other unrelated values. If it is not a typo, you could simplify the appearance of your code by putting everyting inside an if-statement conditional on that test. 

if ( defined $result_ref->{agency_id} and  $result_ref->{agency_id} ) 
+{
  get_updates($objects[0], 'agency_id', $result_ref->{'agency_id'});

  get_updates($objects[1], 'advertiser', $result_ref->{'advertiser'})
    if defined $result_ref->{'advertiser'};

  get_updates($objects[2], 'campaign_id', $result_ref->{'campaign_id'}
+)
    if defined $result_ref->{'campaign_id'};

  get_updates($objects[3], 'contact_id', $result_ref->{'admin_contact_
+id'})
    if defined $result_ref->{'admin_contact_id'};

  get_updates($objects[3], 'contact_id', $result_ref->{'tech_contact_i
+d'})
    if defined $result_ref->{'tech_contact_id'};
);

[download]

the lowliest monk

In reply to Re: How would you rewrite this? by tlm
in thread How would you rewrite this? by jacques

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.