I was uncertain whether the 5th call should have had  objects[4] -- in fact, maybe there are "copy/paste" problems in both the 4th and 5th calls.

If the calls were supposed to follow a regular pattern (as opposed to the last two calls breaking the pattern), then this would be how I would phrase it: 

if ( $result_ref{'agency_id'} != 0 )
{
    my $i = 0;
    for my $k (qw/agency_id advertiser campaign_id admin_contact_id te
+ch_contact_id)
    {
        get_updates($objects[$i++], $k, $result_ref->{$k})
             if (defined $result_ref->{$k});
    }
}

[download]
On the other hand, if the last two calls are supposed to be exactly as in the OP (and do not follow a regular a pattern), then make an extra array or hash to provide the necessary values for the index into @objects and for the second arg to get_updates().

In reply to Re: How would you rewrite this? by graff
in thread How would you rewrite this? by jacques

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.