Note that your code doesn't follow the original with regard to the index. You only increase the index if the if branch is evaluated. You need to increase $i outside the if. I'd probably rewrite it to this though: 

my @fields = qw/ ... /;
for (0 .. $#fields) {
  get_updates($objects[$_], $fields[$_], $result_ref->{$fields[$_]}
    if defined $result_ref->{$fields[$_]};
}

[download]
A structure like that doesn't invite to get things out of sync.

ihb

See perltoc if you don't know which perldoc to read!

In reply to Re^2: How would you rewrite this? by ihb
in thread How would you rewrite this? by jacques

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.