You can improve that. 
my @checks = (
 [ qw/0 agency_id agency_id / ],
 [ qw/1 advertiser advertiser / ],
 [ qw/2 compaign_id compaign_id / ],
 [ qw/3 contact_id admin_contact_id / ],
 [ qw/3 contact_id tech_contact_id / ],
);
foreach my $check (@checks){
    my( $idx, $key, $k ) = @$check;

    (defined $result_ref->{$k} && $result_ref->{$k} != 0)
        && get_updates($objects[$idx], $key, $result_ref->{$k});
}

[download]

Note that means that $result_ref->{$k} is allowed to be the empty string. If it's not, then it's better written as a simple check for boolean truth. 

    $result_ref->{$k}
        && get_updates($objects[$idx], $key, $result_ref->{$k});

[download]

In Perl6, that could look like: 

my @checks = qw(
    0 agency_id agency_id
    1 advertiser advertiser
    2 compaign_id compaign_id
    3 contact_id admin_contact_id
    3 contact_id tech_contact_id
);

for (@checks) -> ($idx, $key, $check) {
    $result_ref->{$check} &&
        get_updates( @objects[$idx], $key, $result_ref->{$check} );
}

[download]

The Perfect is the Enemy of the Good.

In reply to Re^2: How would you rewrite this? by dragonchild
in thread How would you rewrite this? by jacques

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.