hmm. the fiddle with two 3 indexes mapping to contact_id makes it kinda ugly but if the order is not important... 
my %stuff = (
    agency_id        => 0,
    advertiser       => 1,
    campaign_id      => 2,
    admin_contact_id => 3,
    tech_contact_id  => 3,
);

get_updates(
    $objects[$stuff{$_}],
    /(contact_id)$/ ? $1 : $_, # ugh
    $result_ref->{$_}
) for grep $result_ref->{$_}, keys %stuff;

[download]
but personally I would add return unless $_[2]; (or whatever you shifted $_[2] into) to get_updates to remove the requirement of checking $result_ref->{$_} every time. 
   larryk                                          
perl -le "s,,reverse killer,e,y,rifle,lycra,,print"

In reply to Re: How would you rewrite this? by larryk
in thread How would you rewrite this? by jacques

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.