my $script = param('select') or "Αρχική Σελίδα!";

$sth = $dbh->prepare( "SELECT host FROM guestlog" );
$sth->execute();
while( $row = $sth->fetchrow_hashref ) {
    if( $host eq $row->{host} ) {
        my $hostmatch = 1;
    }
}

if( param('select') and param('select') !~ /\.\./ )
{
   open(FILE, "<../data/text/$script.txt") or die $!;
        my @data = <FILE>;
   close(FILE);

    my $data = join('', @data);

    $dbh->do( "UPDATE guestlog SET script='$script' WHERE host='$host'
+" ) or die $dbh->errstr;
}
elsif( $hostmatch == 1 )
{
    $dbh->do( "UPDATE guestlog SET hostcount = hostcount + 1 WHERE hos
+t='$host'" ) or die $dbh->errstr;
    $sth = $dbh->prepare( "SELECT * FROM guestlog WHERE host='$host'" 
+);
    $sth->execute();
    $row = $sth->fetchrow_hashref;

    $data = "Καλώς ήλθες " .$host. "! Χαίρομαι που βρίσκες την σελίδα 
+ενδιαφέρουσα!\n" .
            "Τελευταία φορά ήρθες εδώ ως " .$row->{host}. " στις " .$r
+ow->{date}. " !!\n" .
            "Σύνολικές ήρθες εδώ " .$row->{hostcount}. " φορές!!!\n" .
            "Τελευταία είδες το κείμενο { " .$row->{script}. " }\n" .
            "Ποιό κείμενο θα μελετήσεςι αυτήν την φορά !?";
}
elsif( $hostmatch != 1 )
{
   if ( $host ne "Νίκος" )
   {
       $data = "Γειά σου " .$host. "!\n" .
               "Έρχεσαι για 1η φορά εδώ !!\n" .
               "Ελπίζω να βρείς τα κείμενα ενδιαφέροντα :-)";

       $dbh->do( "INSERT INTO guestlog VALUES (null, '$host', '$date',
+ '$script', 1, 1)" ) or die $dbh->errstr;
   }
   else
   {
       $data = "Γειά σου Νικόλα, τι χαμπάρια?! Όλα δεξιά να σου πάνε π
+άντα! ;-)";
   }
}

[download]
ok with the above script iam trying to see if the current hostname of a visitor exists in guestlog mysql database. If it does then i just update the existing record, if it does not i just welcome the user. Please you asked me to ask specific questions and here i ask one: Is the above logic correct? Is there any betetr that i can write it? ps. Sorry about the Greek folks but although i use UTF-8 it still being displayed like shit. I hate seeing it myself too but i donw know how can they be displayed correctly.

In reply to Is this logic correct? Maybe can be rewritten better? by Nik

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.