Your vulnerable to SQL injection attacks. For example, $script is not validated in

my $script = param('select') or ...;
...
$dbh->do("UPDATE guestlog SET script='$script' WHERE host='$host'");

[download]

Escape special characters within $script (and $host and $date) using $dbh->quote, or better yet, bind the arguments as shown here:

my $script = param('select') or ...;
...
$dbh->do("UPDATE guestlog SET script=? WHERE host=?", undef, $script, 
+$host);

[download]

The same applies to prepare. For example,

$sth = $dbh->prepare( "SELECT * FROM guestlog WHERE host='$host'");
$sth->execute();

[download]

becomes

$sth = $dbh->prepare("SELECT * FROM guestlog WHERE host=?");
$sth->execute($host);

[download]

By the way, this site uses iso-latin-1 (ISO-8859-1), not UTF-8. You'll have to use HTML entities such as &#xxxx; if you want to display characters outside of iso-latin-1. Unfortunately, those won't work within <code> tags.

In reply to Re: Is this logic correct? Maybe can be rewritten better? by ikegami
in thread Is this logic correct? Maybe can be rewritten better? by Nik

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.