Don't forget to use strict; and use warnings; (or -w). Additionally, you may be interested in use diagnostics; which expounds upon perl's error messages, which returned (for the above code):

Bareword found where operator expected at ./tmp line 20, near "$%error_msgs" (#1)
    (S syntax) The Perl lexer knows whether to expect a term or an operator.
    If it sees what it knows to be a term when it was expecting to see an
    operator, it gives you this warning.  Usually it indicates that an
    operator or delimiter was omitted, such as a semicolon.
(Missing operator before error_msgs?) syntax error at ./tmp line 17, near ") ) " Global symbol "$error_msgs" requires explicit package name at ./tmp line 18. syntax error at ./tmp line 22, near "}" Execution of ./tmp aborted due to compilation errors (#2) (F) Probably means you had a syntax error. Common reasons include: A keyword is misspelled. A semicolon is missing. A comma is missing. An opening or closing parenthesis is missing. An opening or closing brace is missing. A closing quote is missing. Often there will be another error message associated with the syntax error giving more information. (Sometimes it helps to turn on -w.) The error message itself often tells you where it was in the line when it decided to give up. Sometimes the actual error is several tokens before this, because Perl is good at understanding random input. Occasionally the line number may be misleading, and once in a blue moon the only way to figure out what's triggering the error is to call perl -c repeatedly, chopping away half the program each time to see if the error went away. Sort of the cybernetic version of S<20 questions>. Uncaught exception from user code: syntax error at ./tmp line 17, near ") ) " Global symbol "$error_msgs" requires explicit package name at ./tmp line 18. syntax error at ./tmp line 22, near "}" Execution of ./tmp aborted due to compilation errors.

Additionally, remember that $name != $error_msgs{'name'}; I think you may be looking for something like:

my %errs = ( name => 'Unspecified', email => 'Invalid' ); my %fields = ( name => 'Bob', email => undef ); foreach (keys %fields) { print $errs{$_} unless $fields{$_}; }

Given the above implementation (in the OP code), you may also be interested in warn and die.


In reply to Re: Better rewrite of multiple ifs by eibwen
in thread Better rewrite of multiple ifs by Nik

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.